Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash in GotoFirstNonBlankOfLine #2051

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Prevent crash in GotoFirstNonBlankOfLine #2051

merged 1 commit into from
Feb 10, 2021

Conversation

springcomp
Copy link
Contributor

@springcomp springcomp commented Dec 17, 2020 •
edited by ghost
Loading

PR Summary

Fixes #2050.

The method GetBeginningOfLinePos is updated to remove call to LineIsMultiline that do not check the buffer input and attempts to access the underlying _buffer. Additionally, the method GetFirstNonBlankOfLogicalLinePos protects access to the _buffer member.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
Microsoft Reviewers: Open in CodeFlow

daxian-dbw
daxian-dbw reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 comment.

@ghost ghost removed the Needs-Author Feedback label Jan 19, 2021
@daxian-dbw daxian-dbw merged commit 9e09968 into PowerShell:master Feb 10, 2021
@ghost
Copy link

ghost commented Feb 23, 2021

🎉 v2.2.0-beta2 has been released which incorporates this pull request. 🎉

@springcomp springcomp deleted the #2050 branch February 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vi-mode] GotoFirstNonBlankOfLine crashes PSRL when buffer is empty
2 participants
@springcomp @daxian-dbw