-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vi-mode] Undo now leaves the cursor under the position at the start of the deletion #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
requested changes
Jan 7, 2021
…replacing the input.
daxian-dbw
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@springcomp Sorry for the looooong delay. I rebased your code and made some refactoring and updates. Will merge this PR shortly.
@daxian-dbw thanks a lot 🙏. I never lost hope 😉. |
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1673
Fixes #2408
This PR changes undo so that a deleted text is inserted in the buffer and resetting the cursor at the position where it was when deletion of text occurred. I believe this is also making it more consistent with how most text editors behave.
To implement this PR I also slightly changed the
AcceptSuggestion
andAcceptNextSuggestionWord
methods which were doing a replacement of the buffer. This PR now makes those methods add the appropriate portion of text so that undoing the operation behaves more inline with most users’ expectations. Externally, the behaviour of those methods has not changed.This PR also changes
SwapCharacters
to make it an atomic operation while still moving the cursor after swapping characters. This preserves the original behaviour. However, it slightly alters the way the cursor is now positioned when undo occurs, but I’m not sure whether this can be seen as a breaking change or not.PR Checklist
Microsoft Reviewers: Open in CodeFlow