-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor usage of clipboard #2022
Refactor usage of clipboard #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring, look mostly good to me, with a few comments.
@daxian-dbw I believe I have addressed all feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will help resolve the conflict.
🎉 |
PR Summary
While working on various upcoming PRs (notably #1674 and #584) I noticed this would be easier if some code cleanup/refactoring had taken place before,
I noticed a common pattern while trying to remove some text while supporting undo:
Therefore, this PR introduces a new method to promote this pattern and refactors all ocurrences to use the new method.
While doing so, I also slightly refactor one or two obvious related changes to the clipboard handling.
PR Checklist
Microsoft Reviewers: Open in CodeFlow