Fix a few issues with the menu completion #1946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes 3 issues with the menu completion:
MenuComplete
#1935 -- regression introduced in 2.2.0-beta1)[NOTE] It's easier to review by ignoring the whitespace changes: https://github.com/PowerShell/PSReadLine/pull/1946/files?w=1 Most line changes are the new tests.
Navigation in menu view
Before the change, the RightArrow and LeftArrow don't work correctly:

After the change, RightArrow and LeftArrow work as expected and you can use either one of RightArrow, LeftArrow, UpArrow, and DownArrow to loop through the menu items.
PR Checklist
Microsoft Reviewers: Open in CodeFlow