Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release build #1930

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Update the release build #1930

merged 4 commits into from
Nov 4, 2020

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 4, 2020 •
edited by ghost
Loading

PR Summary

Update the release build:

  • Use a new builder pool, which has the latest PowerShell 7.0.3 available.
  • Remove catalog related steps, as the catalog file is unnecessary to PowerShell Gallery now.
  • Update the signing xml file to sign the new "Polyfiller" assemblies.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Update the pool to use
3cdee0c
@daxian-dbw
Update release build to:
d51d5cd 
1. Update the signing xml file
2. Remove catalog related steps
@daxian-dbw
Update pool name again
62adf3f
@daxian-dbw
Copy link
Member Author

This change has been verified with the Azure DevOps build https://dev.azure.com/mscodehub/PSReadLine/_build/results?buildId=158037&view=results

adityapatwardhan
adityapatwardhan suggested changes Nov 4, 2020
View reviewed changes
.vsts-ci/releaseBuild.yml
@@ -17,7 +17,7 @@ resources:

jobs:
- job: build_windows
pool: Package ES Lab A
pool: Package ES CodeHub Lab E
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the standard pool Package ES Standard Build. Did you have problems using it? It seems you had it in one of your previous commits

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the build didn't start when using Package ES Standard Build. It says something like "it doesn't exist or I don't have permission". I copied this one from Paul's SecretManagement release build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just sent the email to request adding the agent pool to PSReadLine. I will update the pool name once the agent pool is added and my access is clear.
Before that, I would like to go with "Package ES CodeHub Lab E", as I need to release 2.2.0-beta1 today or tomorrow.

adityapatwardhan
adityapatwardhan approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when the pool is changed.

@daxian-dbw daxian-dbw merged commit 417fe5c into PowerShell:master Nov 4, 2020
@daxian-dbw daxian-dbw deleted the release-build branch November 4, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@lzybkr lzybkr Awaiting requested review from lzybkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxian-dbw @SteveL-MSFT @adityapatwardhan