Fix a null-ref exception in DynamicHelpImpl (#2292)

PowerShell · Mar 11, 2021 · dc38b45 · dc38b45
1 parent f8fb650
commit dc38b45
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/PSReadLine/DynamicHelp.cs b/PSReadLine/DynamicHelp.cs
@@ -151,6 +151,9 @@ private void DynamicHelpImpl(bool isFullHelp)
             string commandName = null;
             string parameterName = null;
 
+            // Simply return if nothing is rendered yet.
+            if (_singleton._tokens == null) { return; }
+
             foreach(var token in _singleton._tokens)
             {
                 var extent = token.Extent;

diff --git a/test/DynamicHelpTest.cs b/test/DynamicHelpTest.cs
@@ -97,6 +97,13 @@ private static PSObject GetParameterHelpObject(string description)
             return paramHelp;
         }
 
+        [SkippableFact]
+        public void DynHelp_GetFullHelp_OnEmptyLine()
+        {
+            TestSetup(KeyMode.Cmd);
+            Test("", Keys(_.F1, _.Enter));
+        }
+
         [SkippableFact]
         public void DynHelp_GetFullHelp()
         {
@@ -108,6 +115,13 @@ public void DynHelp_GetFullHelp()
                 ));
         }
 
+        [SkippableFact]
+        public void DynHelp_GetParameterHelp_OnEmptyLine()
+        {
+            TestSetup(KeyMode.Cmd);
+            Test("", Keys(_.Alt_h, _.Enter));
+        }
+
         [SkippableFact]
         public void DynHelp_GetParameterHelp_And_Clear()
         {