Use 'd^' to delete from the first non-blank character of a logical li…

…ne (#2001)
PowerShell · Dec 7, 2020 · 352edb9 · 352edb9
1 parent a7fd34f
commit 352edb9
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/PSReadLine/PSReadLineResources.resx b/PSReadLine/PSReadLineResources.resx
@@ -476,7 +476,7 @@ If there are other parse errors, unresolved commands, or incorrect parameters, s
     <value>Switches to insert mode after positioning the cursor past the end of the line.</value>
   </data>
   <data name="DeleteLineToFirstCharDescription" xml:space="preserve">
-    <value>Deletes all of the line except for leading whitespace.</value>
+    <value>Deletes from the first non blank character of the current logical line in a multiline buffer.</value>
   </data>
   <data name="BackwardReplaceCharDescription" xml:space="preserve">
     <value>Replaces the character in front of the cursor.</value>

diff --git a/PSReadLine/ReadLine.vi.cs b/PSReadLine/ReadLine.vi.cs
@@ -722,14 +722,7 @@ public static void DeleteLineToFirstChar(ConsoleKeyInfo? key = null, object arg
         {
             if (_singleton._current > 0)
             {
-                int i = 0;
-                for (; i < _singleton._current; i++)
-                {
-                    if (!Char.IsWhiteSpace(_singleton._buffer[i]))
-                    {
-                        break;
-                    }
-                }
+                var i = GetFirstNonBlankOfLogicalLinePos(_singleton._current);
 
                 _singleton.SaveToClipboard(i, _singleton._current - i);
                 _singleton.SaveEditItem(EditItemDelete.Create(_clipboard, i, DeleteLineToFirstChar));

diff --git a/test/BasicEditingTest.VI.cs b/test/BasicEditingTest.VI.cs
@@ -549,6 +549,25 @@ public void ViDeleteToEnd()
                 ));
         }
 
+        [SkippableFact]
+        public void ViDeleteLineToFirstChar()
+        {
+            TestSetup(KeyMode.Vi);
+
+            int continuationPrefixLength = PSConsoleReadLineOptions.DefaultContinuationPrompt.Length;
+
+            Test("\"\n   some spaces\n\"", Keys(
+                _.DQuote, _.Enter,
+                "   this is a line with some spaces", _.Enter,
+                _.DQuote, _.Escape,
+                "k6W",
+                CheckThat(() => AssertCursorLeftIs(continuationPrefixLength + 23)),
+                // delete from first non blank of line
+                "d^",
+                CheckThat(() => AssertCursorLeftIs(continuationPrefixLength + 3))
+            ));
+        }
+
         [SkippableFact]
         public void ViDeleteNextLines()
         {