Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: add copy files for *-from-file configuration directives #94

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

SrX
Copy link
Contributor

@SrX SrX commented Jan 30, 2023

No description provided.

tasks/configure.yml Show resolved Hide resolved

- block:

- name: Ensure that the PowerDNS Recursor configuration from-files directory exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block indentation require some extra indentation of tasks inside it.
https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_blocks.html#grouping-tasks-with-blocks

README.md Outdated
```

List of files to copy to the PowerDNS Recursor instance, could be used for the `*-from-file` settings in the `recursor.conf` configuration file.
The `pdns_rec_config_from_files_dir_mode` allow to change the mode of files if required.
Copy link
Contributor

@npmdnl npmdnl Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allows changing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@SrX SrX requested a review from npmdnl February 9, 2023 10:09
Copy link
Contributor

@npmdnl npmdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npmdnl npmdnl merged commit 4914406 into master Mar 3, 2023
@npmdnl npmdnl deleted the ssp-rec-from-files branch March 3, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants