Fixes #70 Role fails to run in check mode. #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set '_pdns_rec_version' by default to 0 to avoid variable undefined errors during check mode.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This is the fix for check mode.
I can't make fix suggested by @Qwiz in #70 (add
check_mode: notoObtain pdns version stringtask) working, because version detection relies on the fact, thatpdns_recursoris indeed installed. But when run in check mode, this may not be the case. Moreover, using 'shell' inObtain pdns version stringtask hides this fact, because pipeline always has return code of last command (which isawk) andawkwill never fail here. But that's (probably) another problem.So, i've just added default value of 0 for
_pdns_rec_version, which may not show accurate results in some cases (when we need to modify systemd override file), but at least make check mode run till the end.