Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support and forward-zones #47

Closed
wants to merge 9 commits into from

Conversation

Godwottery
Copy link

Added support for installing powedns-recursor on FreeBSD
Added support for managing forward-zones from Ansible

Copy link
Contributor

@pieterlexis pieterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! I have 2 suggestions so current behaviour is unmodified, along with these comments:

Can you add this to defaults/main.yml:

pdns_rec_forward_zones: []

Can you mention in the README that on FreeBSD, the repository options are not honored?

Could you add FreeBSD to the supported systems in meta/galaxy.yml?

I'm not a fan of using hashes for config options, perhaps changing pdns_fileowner to pdns_rec_file_owner and pdns_rec_file_group is cleaner.

And YAML lint is complaining:

--> Executing Yamllint on files found in /home/travis/build/PowerDNS/pdns_recursor-ansible/...
    /home/travis/build/PowerDNS/pdns_recursor-ansible/tasks/install-FreeBSD.yml
      7:1       error    too many blank lines (1 > 0)  (empty-lines)

tasks/configure.yml Outdated Show resolved Hide resolved
tasks/configure.yml Outdated Show resolved Hide resolved
@Godwottery
Copy link
Author

Can you add this to defaults/main.yml:
Done

Can you mention in the README that on FreeBSD, the repository options are not honored?
Added

Could you add FreeBSD to the supported systems in meta/galaxy.yml?
Fixed in meta/main.yml, under the galaxy section. I assume that is what you meant.

I'm not a fan of using hashes for config options, perhaps changing pdns_fileowner to pdns_rec_file_owner and pdns_rec_file_group is cleaner.
See comment above

And YAML lint is complaining:
Fixed

@Godwottery
Copy link
Author

Test failure: fatal: [centos-6]: FAILED! => {"changed": false, "msg": "Failure talking to yum: Cannot find a valid baseurl for repo: base"}
Does not seem to be causes by this PR.

pieterlexis added a commit to pieterlexis/pdns_recursor-ansible that referenced this pull request Sep 15, 2020
Reuses ideas and elements by @Godwottery from PowerDNS#47. Changes the following
things:

 * FreeBSD support added
 * File ownership can now be configured with variables
@pieterlexis
Copy link
Contributor

I've re-created your contribution in #64 as it diverged too much. Thanks for starting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants