Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role refactoring to address #11 #19

Merged
merged 14 commits into from
Nov 9, 2016
Merged

Role refactoring to address #11 #19

merged 14 commits into from
Nov 9, 2016

Conversation

atosatto
Copy link
Contributor

@atosatto atosatto commented Sep 8, 2016

This PR contains some breaking changes to attempt fix PR #11.

  • Removed the url installation method (in case, we still need a commit to remove it from the doc)
  • Added actions to query the APT/YUM repositories to get the available pdns_recursor package version
  • Configuring the pdns_recursor before actually installing it

Off course, this is open for discussion.

@atosatto
Copy link
Contributor Author

atosatto commented Sep 9, 2016

Well, as discussed on IRC with @pieterlexis and @Habbie, I've replace in 7a372fa the awk shell trick to obtain the available pdns-recursor package list from the remote repos with custom modules miming the apt-cache madison command.

@atosatto atosatto changed the title Experimental PR to fix issue #11 Role refactoring to address #11 Oct 21, 2016
@atosatto
Copy link
Contributor Author

@Habbie and @pieterlexis this PR is now completed.
It's a lot of stuff but I really would like to hear some feedbacks from you (and hopefully get you merge it).

@atosatto
Copy link
Contributor Author

atosatto commented Oct 21, 2016

To test all the stuff (if you have Vagrant and Virtualbox installed) and see how it does work:

# Install molecule
$ pip install molecule

# Get the available test platforms
$ molecule list
AVAILABLE PLATFORMS
centos-7       (default)
ubuntu-xenial
debian-jessie

# Test on a platform (eg. ubuntu-xenial)
$ molecule converge --platform=ubuntu-xenial

# Cleanup everything
$ molecule destroy

The executed test playbook is playbook.yml in the project root directory.

@pieterlexis
Copy link
Contributor

👍 lgtm!

@atosatto atosatto merged commit c3ba3de into PowerDNS:master Nov 9, 2016
@atosatto atosatto deleted the f-freakyexperiments branch November 9, 2016 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants