Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: fix two issues building rec using meson on debian11 #15085

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

omoerbeek
Copy link
Member

  1. Local arc4random was not declared as dependency
  2. libresolv was not found (no pkgconfig file) but is still needed

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

1. Local arc4random was not declared as dependency
2. libresolv was not found (no pkgconfig file) but is still needed
@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12951709444

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.722%

Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/packethandler.cc 3 72.4%
pdns/recursordist/syncres.cc 3 80.56%
modules/gpgsqlbackend/spgsql.cc 3 67.46%
pdns/dnsdistdist/dnsdist-lbpolicies.cc 4 70.77%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.87%
pdns/remote_logger.cc 6 52.47%
pdns/recursordist/test-syncres_cc1.cc 7 89.8%
Totals Coverage Status
Change from base Build 12944046345: 0.02%
Covered Lines: 127861
Relevant Lines: 166480

💛 - Coveralls

@omoerbeek omoerbeek requested review from rgacogne and Habbie January 24, 2025 15:07
@omoerbeek omoerbeek merged commit 231e853 into PowerDNS:master Jan 24, 2025
81 checks passed
@omoerbeek omoerbeek deleted the rec-meson-deb11 branch January 24, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants