Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boring minor cleanups #15084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

@miodvallat miodvallat commented Jan 24, 2025

Short description

This innocent-looking PR attempts to clean a few minor things:

  • address documentation build warnings
  • address code build warnings when building the authoritative server by moving static code within the #ifdef ... #endif blocks which is its only user.

There is no guarantee you won't fall asleep out of boredom while looking at it.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code (really)
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • warned reviewers about the soporific nature of this PR

@miodvallat miodvallat force-pushed the fire_of_unknown_origin branch from 7a340dc to 7da68ae Compare January 24, 2025 13:16
@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12950402165

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+8.3%) to 73.014%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/recursor_cache.cc 1 84.29%
pdns/misc.cc 2 62.66%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/misc.hh 3 87.62%
pdns/packethandler.cc 3 72.4%
pdns/remote_logger.cc 3 53.81%
modules/gpgsqlbackend/spgsql.cc 3 67.46%
pdns/dnsdistdist/dnsdist-lbpolicies.cc 4 70.3%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.6%
pdns/signingpipe.cc 10 83.38%
Totals Coverage Status
Change from base Build 12944046345: 8.3%
Covered Lines: 26501
Relevant Lines: 34250

💛 - Coveralls

pdns/tcpiohandler.cc Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants