Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: having a non-default forwarding_catalog_zones does not conflict with Lua config #15058

Conversation

omoerbeek
Copy link
Member

Fixes #15052

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12864213736

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6805 unchanged lines in 98 files lost coverage.
  • Overall coverage decreased (-3.4%) to 61.262%

Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/recursordist/sortlist.hh 1 75.0%
ext/json11/json11.cpp 1 64.49%
pdns/dnstap.cc 2 68.82%
pdns/dnsname.hh 2 91.4%
pdns/ws-api.cc 2 84.91%
pdns/version.cc 2 93.84%
modules/lmdbbackend/lmdbbackend.cc 2 73.58%
ext/probds/murmur3.cc 2 88.24%
pdns/recursordist/secpoll-recursor.cc 2 50.0%
Totals Coverage Status
Change from base Build 12832418127: -3.4%
Covered Lines: 121930
Relevant Lines: 166101

💛 - Coveralls

@omoerbeek
Copy link
Member Author

omoerbeek commented Jan 20, 2025

Back to the drawing board. Looks like this innocent looking change breaks the FWCatz.

This is because the dynamic parts of YAML processing is only done if no Lua config is active. And the FWCatz are a dynamic part. To make an exception for FWCats would require a major reshuffling and as we want people to move to YAML anyway I don't think this wil happen.

@omoerbeek omoerbeek closed this Jan 20, 2025
@omoerbeek omoerbeek deleted the rec-forwarding_catalog_zones-default branch January 20, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring 'forwarding_catalog_zones' in recursor forces user to migrate settings from 'lua_config_file'
2 participants