Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Coverity issues missed in last round, all severity "Low" #15057

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

omoerbeek
Copy link
Member

1587809 Variable copied when it could be moved
1587817 Variable copied when it could be moved
1587819 Variable copied when it could be moved

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

1587809 Variable copied when it could be moved
1587817 Variable copied when it could be moved
1587819 Variable copied when it could be moved
@omoerbeek omoerbeek added the rec label Jan 20, 2025
@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Jan 20, 2025
@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12864148548

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 261 unchanged lines in 25 files lost coverage.
  • Overall coverage decreased (-0.001%) to 64.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec-zonetocache.cc 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/validate.cc 1 68.71%
pdns/recursordist/recursor_cache.cc 1 84.09%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/misc.hh 3 87.62%
pdns/packethandler.cc 3 73.05%
pdns/recursordist/negcache.hh 3 82.35%
pdns/recursordist/lwres.cc 3 69.66%
pdns/opensslsigners.cc 3 61.34%
pdns/recursordist/recursor_cache.hh 3 90.1%
pdns/rcpgenerator.cc 3 90.82%
Totals Coverage Status
Change from base Build 12832418127: -0.001%
Covered Lines: 127779
Relevant Lines: 166435

💛 - Coveralls

@omoerbeek omoerbeek merged commit ad4c52c into PowerDNS:master Jan 20, 2025
81 checks passed
@omoerbeek omoerbeek deleted the rec-coverity-20250120 branch January 20, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants