Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully on ^D on control-console #15041

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

miodvallat
Copy link
Contributor

@miodvallat miodvallat commented Jan 15, 2025

Fixes: #1694

Short description

This changes DynListener to register the "quit" function separately from other functions, and then pretend this function name has been typed when the file descriptor gets closed.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12790835357

Details

  • 7 of 19 (36.84%) changed or added relevant lines in 2 files are covered.
  • 100 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/auth-main.cc 1 6 16.67%
pdns/dynlistener.cc 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
pdns/dynlistener.cc 1 37.62%
pdns/recursordist/aggressive_nsec.cc 2 66.39%
pdns/ws-auth.cc 2 80.8%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/packethandler.cc 3 72.44%
pdns/remote_logger.cc 3 54.26%
pdns/recursordist/rec-tcp.cc 10 66.07%
pdns/recursordist/taskqueue.cc 11 34.15%
pdns/recursordist/syncres.cc 14 80.07%
modules/lmdbbackend/lmdbbackend.cc 17 72.91%
Totals Coverage Status
Change from base Build 12766545506: -0.03%
Covered Lines: 126310
Relevant Lines: 163852

💛 - Coveralls

@Habbie
Copy link
Member

Habbie commented Jan 16, 2025

I.. forgot we had this! I wonder if anybody uses it :)

@miodvallat
Copy link
Contributor Author

Ten years is a good timespan to forget about issues 😁

@Habbie
Copy link
Member

Habbie commented Jan 16, 2025

Ten years is a good timespan to forget about issues 😁

i meant the entire control-console :D

@miodvallat
Copy link
Contributor Author

It is carefully documented as "you're not tall enough to ride".

@miodvallat miodvallat merged commit be01686 into PowerDNS:master Jan 16, 2025
81 checks passed
@miodvallat miodvallat deleted the guillotine branch January 16, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken behaviour when stdin is closed
3 participants