Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Document dnsdist_ffi_stat_node_get_children_* return children+node stats #15037

Merged

Conversation

rgacogne
Copy link
Member

Short description

The dnsdist_ffi_stat_node_get_children_* methods return the sum of the queries or responses received for the children of a node AND the node itself. It's quite unexpected but breaking the existing behaviour now would be painful.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

…ren+node stats

The `dnsdist_ffi_stat_node_get_children_*` methods return the sum of
the queries or responses received for the children of a node AND the node
itself. It's quite unexpected but breaking the existing behaviour now would be painful.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12765583697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-9.2%) to 64.916%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.44%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/recursor_cache.cc 1 84.42%
modules/lmdbbackend/lmdbbackend.cc 2 73.74%
pdns/rcpgenerator.cc 2 90.55%
pdns/misc.hh 3 87.62%
pdns/misc.cc 4 64.68%
pdns/recursordist/syncres.cc 5 80.04%
pdns/signingpipe.cc 5 83.38%
Totals Coverage Status
Change from base Build 12765482410: -9.2%
Covered Lines: 126368
Relevant Lines: 163844

💛 - Coveralls

@rgacogne rgacogne merged commit a10c335 into PowerDNS:master Jan 16, 2025
81 checks passed
@rgacogne rgacogne deleted the ddist-document-stat-node-ffi-children branch January 16, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants