Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Use getAddressInfo() instead python daemonized subprocess #15032

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

metajiji
Copy link
Contributor

Short description

Use integrated getAddressInfo() function instead python script dockerdata/dnsdist-resolver.py.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12746749069

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.004%) to 64.892%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 66.73%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/packethandler.cc 3 72.4%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/rec-main.cc 3 62.4%
pdns/recursordist/syncres.cc 6 80.15%
pdns/recursordist/rec-tcp.cc 9 64.98%
Totals Coverage Status
Change from base Build 12745616875: 0.004%
Covered Lines: 126294
Relevant Lines: 163805

💛 - Coveralls

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@rgacogne rgacogne merged commit 45b9da6 into PowerDNS:master Jan 16, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants