Followup to #14705: clang-tidy does not pick up last option listed

[omoerbeek]

Short description

This is a quick fix, maybe there are better ways.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[coveralls]

Pull Request Test Coverage Report for Build 11215794940

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1308 unchanged lines in 27 files lost coverage.
• Overall coverage increased (+0.03%) to 64.722%

---

Files with Coverage Reduction	New Missed Lines	%
pdns/recursordist/aggressive_nsec.cc	2	66.02%
pdns/recursordist/test-syncres_cc2.cc	3	88.91%
pdns/dnsdistdist/dnsdist-lua-ffi.hh	3	72.22%
pdns/axfr-retriever.cc	3	67.07%
modules/gpgsqlbackend/spgsql.cc	3	67.46%
pdns/recursordist/reczones-helpers.cc	4	88.97%
pdns/dnsdistdist/dnsdist-tcp.cc	5	76.53%
pdns/recursordist/recursor_cache.hh	5	93.07%
pdns/rcpgenerator.cc	5	89.41%
pdns/recursordist/test-syncres_cc1.cc	6	89.71%

Totals
Change from base Build 11066510928:	0.03%
Covered Lines:	125064
Relevant Lines:	162472

---

💛 - Coveralls

[fredmorcos]

Is the correct fix perhaps to remove the spaces before the # yamllint comments? Did you try that?

[omoerbeek]

Zapping the leading spaces does work and looks a bit cleaner.

[fredmorcos]

Are you sure this fix actually fixes the problem?
I was referring to removing the spaces before the yamllint comment, not before the value in the yaml key: |\n value pair.

Please look at your eglot status buffer, it might be that clang-tidy is erroring out and not running at all and that's why the endl warnings aren't showing up anymore. Not because this change actually fixed the problem.

[fredmorcos]

See comment above

[omoerbeek]

I don't see any spaces before # yamllint, it starts immediately after newline, so I don't get what you're hinting at.

No errors in the eglot-stderr-buffer, other eglot annotations are produced.

Playing a bit, it looks like there's some interaction with CheckOptions: that depends on the exact formatting of the Checks: entry, but sow far not been able to nail it exactly.