Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'cannot read toString() of null' in SelectGradientOverflow #4666

Closed
wants to merge 2 commits into from
Closed

Fix 'cannot read toString() of null' in SelectGradientOverflow #4666

wants to merge 2 commits into from

Conversation

samwinslow
Copy link
Contributor

@samwinslow samwinslow commented Jun 9, 2021 •
edited
Loading

Changes

Fixes #4665; note that PR #4662 may have caused the bug and was reverted.

This PR adds and additional coercion to empty string rather than null, which directly addresses the failure at render-time.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • Frontend/CSS is usable at 320px (iPhone SE) and decent at 360px (most phones)

@timgl timgl temporarily deployed to posthog-pr-4666 June 9, 2021 14:22 Inactive
@samwinslow samwinslow requested a review from tiina303 June 9, 2021 14:25
@samwinslow samwinslow marked this pull request as draft June 9, 2021 14:52
@timgl timgl temporarily deployed to posthog-pr-4666 June 9, 2021 15:31 Inactive
@samwinslow samwinslow closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiina303 tiina303 Awaiting requested review from tiina303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a filter in Sessions page crashes
3 participants
@samwinslow @timgl @yakkomajuri