-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use trends legend graph everywhere #4646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 great stuff! made some minor changes to follow naming conventions and decided to feature flag the total column because we need to handle the special case of unique users, because the plain sum could cause confusion (as it would likely lead to duplicate users because it's not unique across the entire period). Let's discuss this in a separate PR.
Changes
Fixes #4484.
This replaces today's non-informative Insight tables with a table display we already have for our line graphs (less the checkbox legend key)
Changes in this CR
<TrendLegend/>
into<InsightsTable/>
P.S. - I didn't change the existing table view for Insights>Sessions>Distributed Session Lengths, because the data looks a bit different than what is required for
<TrendTable/>
and would need super specific data munging. For this reason, I fallback to<ActionsTable/>
as shown here. Let's deprecate this later (or at least refactor. It seems overdue for some cleanup)Before
After (for Trends, Sessions, and Stickiness tabs)
Checklist