Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support funnel trends conversion window #4618

Merged
merged 5 commits into from
Jun 8, 2021
Merged

Support funnel trends conversion window #4618

merged 5 commits into from
Jun 8, 2021

Conversation

buwilliams
Copy link
Contributor

@buwilliams buwilliams commented Jun 7, 2021 •
edited
Loading

Changes

  • Added conversion window in days to the frontend

Closes #3877

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • Frontend/CSS is usable at 320px (iPhone SE) and decent at 360px (most phones)

@buwilliams buwilliams requested a review from EDsCODE June 7, 2021 15:29
@timgl timgl temporarily deployed to posthog-pr-4618 June 7, 2021 15:31 Inactive
@timgl timgl temporarily deployed to posthog-pr-4618 June 8, 2021 13:29 Inactive
@timgl timgl temporarily deployed to posthog-pr-4618 June 8, 2021 14:19 Inactive
@buwilliams buwilliams self-assigned this Jun 8, 2021
@timgl timgl temporarily deployed to posthog-pr-4618 June 8, 2021 16:55 Inactive
EDsCODE
EDsCODE approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buwilliams buwilliams merged commit bdc1ab6 into master Jun 8, 2021
@buwilliams buwilliams deleted the support-funnel-trends-conversion-window branch June 8, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees

@buwilliams buwilliams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Funnel conversion rate appears to change, even after the window has closed.
3 participants
@buwilliams @EDsCODE @timgl