Return default url if no changes need to be made #4481

EDsCODE · 2021-05-25T16:53:57Z

Changes

Please describe.

wip: support test_ api key #4206 made changes to Api and added a helper. It was missing default condition
If this affects the frontend, include screenshots.

All querysets/queries filter by Organization, by Team, and by User
Django backend tests
Jest frontend tests
Cypress end-to-end tests
Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

buwilliams

Nice catch!

EDsCODE · 2021-05-25T20:35:14Z

**additional changes to make sure test caching includes requirements-dev.txt (it does by default if you remove the explicit argument)

return as last conditoin

6c16358

EDsCODE requested a review from buwilliams May 25, 2021 16:53

buwilliams approved these changes May 25, 2021

View reviewed changes

timgl temporarily deployed to posthog-pr-4481 May 25, 2021 16:57 Inactive

EDsCODE enabled auto-merge (squash) May 25, 2021 16:59

empty

7230493

EDsCODE temporarily deployed to posthog-pr-4481 May 25, 2021 19:09 Inactive

Merge branch 'master' into patch-api-helper

ccbfea1

EDsCODE temporarily deployed to posthog-pr-4481 May 25, 2021 19:15 Inactive

try glob

d369cbd

EDsCODE deployed to posthog-pr-4481 May 25, 2021 20:19 View deployment

EDsCODE disabled auto-merge May 25, 2021 20:22

remove explicit glob

26b0b40

EDsCODE temporarily deployed to posthog-pr-4481 May 25, 2021 20:26 Inactive

EDsCODE merged commit 2145d5b into master May 25, 2021

EDsCODE deleted the patch-api-helper branch May 25, 2021 20:35