-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate team invite signup to React - Part II (Front-end) #3300
Conversation
3179d1b
to
298b43e
Compare
Wow @Twixes thanks for the very thorough review 🙌, you rock! Code comments I'll address directly on each thread. UX comments below,
|
Re 4. auto login vs. signup, that is a slight downside on Cloud. However such a user could find that out anyway, since signup will simply not proceed if the email already is in the database, only leading to confusion for valid users AND information for malicious ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Only a couple of wording clarity notes.
And "Already have an account? Log in" appears twice. 🤔 Actually it did earlier too, I just missed that it's awkward and now it's even more so, as they are both centered.
Actionables for other PRs (will make relevant issues):
- choose between signup and login automatically (prerequisite: React login page)
- join/create organization without need for full page reload
- allow for optional trailing slash in frontend router
All final comments addressed, will merge after tests pass. Thanks for tracking the follow-up items! |
Changes
Builds up on #2734 to support accepting team invites on a React FE, instead of a static Django page, which among other things:
Main functionality
Edge cases
Additional changes
Checklist