Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): add cumulative exposures chart #28898

Merged
merged 8 commits into from
Feb 19, 2025

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Feb 18, 2025

Changes

Adds a chart to display cumulative exposures from ExperimentExposuresQueryRunner. The chart shows for running experiments that use the new metrics.

Notes:

  • The chart should show the full time series for the experiment's duration. However, some initial days may have no exposures. To handle this, I prefill the time series with zeroes programmatically since AFAIK achieving this directly with the query seems tricky.
  • Variant colors aren’t working yet because they rely on the insight field, which is currently missing. Added a TODO in our working doc.
  • Removed old CumulativeExposuresChart which was never rolled out.
image

How did you test this code?

  • Updated query runner tests to account for backfilling initial zero-days.
  • 👀

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@jurajmajerik jurajmajerik requested a review from a team February 18, 2025 22:12
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Size Change: 0 B

Total Size: 1.21 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.21 MB

compressed-size-action

Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

CleanShot 2025-02-18 at 14 39 01@2x

Just need to fix the "I just launched my experiment" scenario:

CleanShot 2025-02-18 at 14 39 32@2x

It'd be good to have a backend test for that, too.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@jurajmajerik jurajmajerik merged commit e5a11f6 into master Feb 19, 2025
101 checks passed
@jurajmajerik jurajmajerik deleted the experiment-exposures-chart branch February 19, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants