feat: new filters for nps trends #28759
Open
+239
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
marandaneto
reviewed
Feb 15, 2025
Comment on lines
+659
to
+662
| date_from: dayjs(values.survey.created_at).format('YYYY-MM-DD'), | ||
| date_to: values.survey.end_date | ||
| ? dayjs(values.survey.end_date).format('YYYY-MM-DD') | ||
| : dayjs().add(1, 'day').format('YYYY-MM-DD'), |
There was a problem hiding this comment.
i think we cna use a const here for YYYY-MM-DD and reuse within the whole page
marandaneto
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NPS Trends lacks personality, and sometimes it's just an huge waste of space
Changes
see before vs after
adds specific filters options for NPS charts:
Does this work well for both Cloud and self-hosted?
N/A
Tests
Smoke tests locally
Unit tests for new logic
Checked if all tests are still running