fix: Zapier description #28723
Merged
fix: Zapier description #28723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the description handling for Zapier integrations, improving clarity and adding migration context when converting legacy hooks to HogFunctions.
- Added
from_migrationparameter inee/api/hooks.pyto control description formatting - Updated template description in
posthog/cdp/templates/zapier/template_zapier.pyto clarify Zapier app usage - Modified migration script in
posthog/management/commands/migrate_hooks.pyto include original hook ID in descriptions - Added description assertions in test files to verify both standard and migration cases
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
meikelmosby
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Didn't quite get the logic right for the description
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?