Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add auth spec to plyrt #28713

Merged
merged 8 commits into from
Feb 14, 2025
Merged

chore: add auth spec to plyrt #28713

merged 8 commits into from
Feb 14, 2025

Conversation

pauldambra
Copy link
Member

auth spec?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added comprehensive Playwright E2E test suite for authentication flows, replacing existing tests with a more robust implementation.

  • Added 8 test cases in /playwright/e2e/auth.spec.ts covering critical auth scenarios like login/logout, failed attempts, and multi-tab sessions
  • Implemented test for Google OAuth integration verification in auth flow
  • Added URL redirect handling tests for both simple and complex URLs post-login
  • Moved credentials to environment variables in /playwright/utils/playwright-test-base.ts with sensible defaults
  • Added auth state persistence between tests for improved performance using cookie/storage caching

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

playwright/e2e/auth.spec.ts Outdated Show resolved Hide resolved
@pauldambra pauldambra merged commit d87352e into master Feb 14, 2025
104 checks passed
@pauldambra pauldambra deleted the chore/cyp-2-ply branch February 14, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant