Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new geoip service #28709

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat: Added new geoip service #28709

wants to merge 17 commits into from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Feb 14, 2025

Problem

The current code path to load mmdb is a mess and we trip over it a bunch.

NEEDS: Changes to deployments to mount the relevant mmdb

Changes

  • Adds a lazyloading GeoipService
  • Simplify to only load from disk
  • Adds a bunch of tests to cover all possible failure modes
  • Need to ensure that with no mmdb locally, every possible startup way downloads it

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

Size Change: -5 B (0%)

Total Size: 1.21 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.21 MB -5 B (0%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant