feat: Destination tests for batch exports #28687
Draft
+804
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/destination-tests-for-batch-exports
branch
from
43f589a to
2dab705
Compare
rossgray
reviewed
Feb 14, 2025
posthog/batch_exports/http.py
Outdated
Comment on lines
529
to
530
| @action(methods=["POST"], detail=True) | ||
| def test(self, request: request.Request, *args, **kwargs) -> response.Response: |
There was a problem hiding this comment.
is this endpoint just for fetching a test (and it's list of steps) for a given batch export?
There was a problem hiding this comment.
Yeah, thought about having everything in a single endpoint, but it looked too complicated. I'd be happy to rename this to something more verbose though...
There was a problem hiding this comment.
I think it does make sense to get a list of possible tests upfront, especially if we want to add them to destinations one at a time, since the frontend could probably not even show a test button if there are no tests to run for example. Was also wondering if it could just be a GET method if it's not actually running anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The most common type error when interacting with batch exports are user configuration errors. This PR introduces a new framework for "Destination tests": Tests that can be called from our API to evaluate a given batch export configuration.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
New unit tests.