-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-warehouse): Build a new postgres source #28660
Merged
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ee89c8a
Updates to sql source and packcages
Gilbert09 709d845
Dev requirements
Gilbert09 9481485
Test out standard json dumps
Gilbert09 bf63f04
JSON upgrade
Gilbert09 3fe8a2c
Pyarrows cleanup
Gilbert09 0d2c945
Add pyarrow debug mode
Gilbert09 2b597bf
mypy updates
Gilbert09 0c9e473
WIP first take on a new postgres source
Gilbert09 1613cf4
Actually use server cursors and iterators for generating tables
Gilbert09 6522aae
Postgres source supports incremental syncs
Gilbert09 c9477fa
mypy updates
Gilbert09 bd32d49
Pyarrow modifications for new postgres source
Gilbert09 79f2343
mypy updates
Gilbert09 0855d39
Merge branch 'master' into tom/new-postgres-source
Gilbert09 5d9864f
mypy updates
Gilbert09 0e6645b
Fixed tests
Gilbert09 b5e5ee4
PR nits
Gilbert09 72ac714
Merge branch 'master' into tom/new-postgres-source
Gilbert09 843a05b
WIP fixes and tests
Gilbert09 fb90f80
Finished off tests for now
Gilbert09 3afeefc
e2e fix
Gilbert09 5600231
another e2e fix
Gilbert09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
posthog/temporal/data_imports/pipelines/pipeline/typings.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import dataclasses | ||
from typing import Any | ||
from collections.abc import Iterable | ||
from dlt.common.data_types.typing import TDataType | ||
|
||
|
||
@dataclasses.dataclass | ||
class SourceResponse: | ||
name: str | ||
items: Iterable[Any] | ||
primary_keys: list[str] | None | ||
column_hints: dict[str, TDataType | None] | None = None # Legacy support for DLT sources |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Using
Any
for items type parameter reduces type safety. Consider using a more specific type or generic type parameter if possible.