chore: add events for migration runs #28637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds event tracking functionality to monitor RBAC migration operations in the organization API, helping track the progress and success of role-based access control implementation.
- Added event tracking in
/posthog/api/organization.pyfor migration start, completion, and failure states - Events include user's distinct ID for tracking migration progress across the organization
- Error messages are captured in failure events for debugging purposes
- Implementation is cloud/self-hosted agnostic as noted in PR description
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
283
to
285
| rbac_team_access_control_migration(organization.id) | ||
| rbac_feature_flag_role_access_migration(organization.id) |
There was a problem hiding this comment.
style: These migrations are run sequentially without transaction management. Consider wrapping both migrations in a single transaction to ensure atomicity.
zlwaterfield
changed the title
27 tasks
patricio-posthog
approved these changes
Feb 13, 2025
zlwaterfield
force-pushed
the
zach/rbac/22
branch
from
2b38c73 to
43746d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow along for RBAC changes: #24512
Adding in event calls for actions
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact.
How did you test this code?
Update mocks for tests