fix: add lemon switch story and fix spacing #28575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the LemonSwitch component's size prop functionality and improves its documentation by ensuring size-specific styles apply consistently across all variants.
- Moved size-specific gap and padding styles from
.LemonSwitch--borderedto main.LemonSwitchblock in/frontend/src/lib/lemon-ui/LemonSwitch/LemonSwitch.scss - Added comprehensive size comparison table in
/frontend/src/lib/lemon-ui/LemonSwitch/LemonSwitch.stories.tsxshowing xsmall/small/medium variants - Maintained min-height calculations specifically for bordered switches while making other size styles universal
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
superseded by #28579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lemon switch only responds to the
sizeprop in styling when bordered