Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add speed word to be aligned with other icons #28569

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

veryayskiy
Copy link
Contributor

The speed icon is different as it does not have text. Let's fix it

Before
Screenshot 2025-02-11 at 22 35 04

After
Screenshot 2025-02-11 at 22 34 43

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated the playback speed label format in the session recording player controller for better UI consistency.

  • Modified label in frontend/src/scenes/session-recordings/player/controller/PlayerController.tsx from '${speed}x' to 'Speed ${speed}x' to match other icon labels

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, we really need to do the "collapse to a menu" work but 🙈

@pauldambra pauldambra enabled auto-merge (squash) February 11, 2025 21:38
Copy link
Contributor

Size Change: -5 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.18 MB -5 B (0%)

compressed-size-action

@pauldambra pauldambra merged commit 7990817 into master Feb 11, 2025
104 checks passed
@pauldambra pauldambra deleted the fix/sr/speed-icon branch February 11, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants