Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show tier table for mobile replay addon when on temporal free plan #28563

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

patricio-posthog
Copy link
Contributor

Problem

If you are in the granfathered plan for Mobile Replay, it only has one tier so we weren't showing the table with usage per tier in the billing page. This will be removed once we migrate all the customers out of this plan. Also minor fix with the top margin in the warning text.

Changes

image

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Cloud

How did you test this code?

Tested locally.

@patricio-posthog patricio-posthog requested a review from a team February 11, 2025 20:09
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the billing tier table display logic to show usage information for mobile replay addon customers on grandfathered free plans, even when only one pricing tier exists.

  • Added product.type === 'mobile_replay' condition in BillingProductPricingTable.tsx to ensure tier table visibility for mobile replay addon
  • Fixed margin spacing by adding mt-2 class to the warning banner for better visual hierarchy
  • Change supports temporary free plan users until they are migrated to standard pricing tiers
  • Maintains backward compatibility for existing grandfathered mobile replay customers

💡 (5/5) You can turn off certain types of comments like style here!

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -212,7 +212,7 @@ export const BillingProductPricingTable = ({
}}
/>
<FeatureFlagUsageNotice product={product as BillingProductV2Type} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Type assertion to BillingProductV2Type might be unsafe if product is actually BillingProductV2AddonType. Consider adding a type guard.

Copy link
Contributor

Size Change: -90 B (-0.01%)

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.18 MB -90 B (-0.01%)

compressed-size-action

@patricio-posthog patricio-posthog merged commit 65990f0 into master Feb 11, 2025
104 checks passed
@patricio-posthog patricio-posthog deleted the patricio/fix-tier-table-for-mobile-addon branch February 11, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants