feat: Add AI Regex Helper to path cleaning #28512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component was tied to the Session Replay usage, it can now be used anywhere
Stealing this component from SessionReplay because it's way too cool to not be used in some other places as well. Regex sucks and this is great for users.
rafaeelaudibert
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR integrates AI-assisted regex generation into the path cleaning feature by replacing the PathRegexPopover with a new PathRegexModal component and reusing the existing AiRegexHelper from session recordings.
- Added new
PathRegexModal.tsxwith AI regex generation support behind thePATH_CLEANING_AI_REGEXfeature flag - Modified
AiRegexHelpercomponent to be more reusable by removing direct dependency onreplayTriggersLogicand adding anonApplycallback prop - Added Storybook stories in
PathRegexModal.stories.tsxto test new rule creation, editing, and AI helper functionality - Improved error handling and user feedback in
aiRegexHelperLogic.tsfor better error cases and API response handling - Added new feature flag
PATH_CLEANING_AI_REGEXinconstants.tsxfor controlled rollout
9 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/lib/components/PathCleanFilters/PathCleanFilterAddItemButton.tsx
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/PathCleanFilters/PathRegexModal.stories.tsx
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/PathCleanFilters/PathRegexModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/components/AiRegexHelper/AiRegexHelper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/components/AiRegexHelper/aiRegexHelperLogic.ts
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/components/AiRegexHelper/aiRegexHelperLogic.ts
Show resolved
Hide resolved
|
Size Change: +48 B (0%) Total Size: 1.18 MB ℹ️ View Unchanged
|
rafaeelaudibert
commented
Feb 10, 2025
frontend/__snapshots__/filters-pathregexmodal--edit-existing-rule--dark.png
Outdated
Show resolved
Hide resolved
If we don't do that, then it doesn't render the whole modal because it's floating
rafaeelaudibert
force-pushed
the
ai-for-path-cleaning
branch
from
bb1ee6a to
dba08f4
Compare
|
Once you agree it does not make sense to have the arrow down anymore.. |
veryayskiy
approved these changes
Feb 11, 2025
veryayskiy
approved these changes
Feb 11, 2025
frontend/src/scenes/session-recordings/components/AiRegexHelper/AiRegexHelper.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regex is tricky to get it right. Path cleaning is pretty powerful. You can't use something powerful if it's tricky.
Changes
Let's reuse Session Replay's amazing
AIRegexHelpercomponent in our PathCleaningRegex UI!I've improved Session Replay's UI along the way as well as a means to thank them for this cool feature :)
Does this work well for both Cloud and self-hosted?
Yep
How did you test this code?
Visually + snapshots will update