feat: Add reddit pixel CDP destination #28493
Open
+517
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
force-pushed
the
feat/add-wip-reddit-pixel
branch
from
95be0cc to
d27f662
Compare
robbie-c
force-pushed
the
feat/add-wip-reddit-pixel
branch
from
2d01b0c to
d9dd697
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a new Reddit Pixel CDP destination that enables tracking user interactions and e-commerce events through Reddit's pixel tracking system, with comprehensive test coverage using STPyV8 for JavaScript execution.
- Added
/posthog/cdp/templates/reddit/template_reddit_pixel.pyimplementing standard e-commerce events (PageVisit, Search, AddToCart) with proper input validation - Added
/posthog/cdp/templates/reddit/test_template_reddit_pixel.pywith test coverage for event tracking and pixel initialization - Introduced
BaseSiteDestinationFunctionTestinhelpers.pyfor testing site destinations using STPyV8 - Added stpyv8==13.1.201.22 as a development dependency for JavaScript code execution in tests
- Integrated Reddit pixel template into CDP framework through
__init__.py
6 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
robbie-c
force-pushed
the
feat/add-wip-reddit-pixel
branch
from
5cb1ff2 to
9ee606a
Compare
robbie-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have a reddit ads CDP destination yet, and a few customers have asked for it
Changes
Add a reddit pixel destination
(A future PR will contain the back-end conversions API destination)
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Created a test page (see PostHog/posthog-js#1725) for manual testing
Added a test class which uses https://github.com/cloudflare/stpyv8 to run the JS code, testing that given events trigger the right calls