feat(experiments): new experiment query and metric interfaces #28367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a significant architectural change to experiment metrics and queries in PostHog, moving from a count-based to a metric-based interface.
- Added new
ExperimentMetricTypeenum inschema.pyto support different metric types (count, continuous, funnel) - Introduced
ExperimentEventMetricConfigandExperimentDataWarehouseMetricConfigclasses for flexible metric configuration - Simplified query runner by removing math aggregation handling in favor of explicit metric types in
experiment_query_runner.py - Restructured query generation to handle different metric types and configurations through a dedicated
self.metricattribute - Updated test suite to validate new metric interfaces and configurations, removing flaky test decorators
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
posthog/schema.py
Outdated
| # Winsorize the metric at a certain percentile threshold, etc. | ||
| # Override priors | ||
| # Is the goal is to increase or decrease the metric, ex. | ||
| inverse: Optional[bool] = False |
There was a problem hiding this comment.
logic: math_hogql and math_property are mutually exclusive - should add validation to ensure only one is set
andehen
added a commit
that referenced
this pull request
Feb 6, 2025
danielbachhuber
pushed a commit
that referenced
this pull request
Feb 11, 2025
danielbachhuber
pushed a commit
that referenced
this pull request
Feb 11, 2025
danielbachhuber
pushed a commit
that referenced
this pull request
Feb 11, 2025
andehen
added a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Introduce new interfaces for experiment queries and metrics.
Still WIP, so ignore all polishing stuff. The important thing here is the new objects in schema.py and how they are to work with and pass around.
How did you test this code?