Plugin v8 #1946
Merged
Plugin v8 #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto master * 'plugins' of github.com:PostHog/posthog: push up ABC class * 'master' of github.com:PostHog/posthog: Update dockerfile for dev-ing (#1817)
* 'plugins' of github.com:PostHog/posthog: unlink symlink
* 'plugins' of github.com:PostHog/posthog: fix fix unlink even if link points to nothing
|
@Twixes I think I got all the points. |
timgl
reviewed
Nov 2, 2020
timgl
reviewed
Nov 2, 2020
plugins/package.json
Outdated
| "license": "MIT", | ||
| "private": true, | ||
| "dependencies": { | ||
| "posthog-plugin-server": "^0.0.6" |
There was a problem hiding this comment.
Wonder if we should hard-pin this version to avoid incompatibility when we change posthog-plugin-server later on
There was a problem hiding this comment.
We do use the .lock-file when installing the packages in this folder, but it can't hurt to be even stricter. Done.
timgl
reviewed
Nov 2, 2020
dev.Dockerfile
Outdated
| @@ -21,6 +21,7 @@ RUN mkdir /code/requirements/ | |||
| COPY requirements/dev.txt /code/requirements/ | |||
| RUN pip install -r requirements/dev.txt --compile | |||
|
|
|||
| COPY posthog.json /code/ | |||
There was a problem hiding this comment.
Trying to build locally failed because this file didn't exist. It's also not in any of the other docker files but could be on purpose
There was a problem hiding this comment.
Hum, that didn't make sense indeed. Just a few lines later with COPY . /code/ it gets copied anyway. Removed.
6 tasks
…esn't exist, copied later anyway)
timgl
approved these changes
Nov 2, 2020
|
Let's do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist