fix(navigation): use min-width for site popover #19415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
daibhin
reviewed
Dec 20, 2023
| @@ -15,7 +15,7 @@ $screens: ( | |||
| 'xxl': $xxl, | |||
| ); | |||
| $tiny_spaces: 0, 0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20; | |||
| $humongous_spaces: 24, 30, 32, 40, 50, 60, 80, 100, 120, 140, 160, 180, 200; | |||
| $humongous_spaces: 24, 30, 32, 40, 50, 60, 70, 80, 100, 120, 140, 160, 180, 200; | |||
There was a problem hiding this comment.
Could we use the 80 value here? It feels like we're adding a variable for a single use - maybe that should be a class
There was a problem hiding this comment.
I had tried the 80 and liked 70 better, hence the addition. I don't think it's too big of an issue though, as tailwind supports arbitrary values https://tailwindcss.com/docs/min-width#arbitrary-values. Meaning when we finally have real tailwind support we can remove all custom spaces and just use the tailwind default ones here.
This was referenced Dec 20, 2023
daibhin
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I still think the site popover could use some additional space when the instance settings are missing (i.e. most users). Might be subjective..
Changes
Before
After
How did you test this code?
👀 when removing the instance settings