Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(3000): Clean up support panel #18968

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Nov 29, 2023

Changes

Addressing #18931 (comment):

Before After
app posthog com_experiments (1) localhost_8000_project_apps

Note how the panel button shadows now point and behave the same way as all other buttons in the UI.

@Twixes Twixes requested a review from corywatilo November 29, 2023 17:53
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite
Copy link
Contributor

Pretty sure David's PR changes these to be the tertiary style which arguably fits better ....

@Twixes Twixes force-pushed the full-width-support-buttons branch from e1593cc to 98150d0 Compare November 29, 2023 18:31
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@corywatilo corywatilo merged commit 3a85190 into master Nov 30, 2023
@corywatilo corywatilo deleted the full-width-support-buttons branch November 30, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants