Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove antd tags #18684

Merged
merged 15 commits into from
Nov 29, 2023
Merged

chore: remove antd tags #18684

merged 15 commits into from
Nov 29, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 16, 2023

Problem

Old tags were not getting 3000 styles

Changes

Replace remaining antd tags

Before After
before after-add-tag
Before After
Screenshot 2023-11-16 at 15 42 50 Screenshot 2023-11-16 at 15 48 22
Before After
Screenshot 2023-11-16 at 15 51 48 Screenshot 2023-11-16 at 16 16 05

How did you test this code?

Screenshots for each case

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

9 snapshot changes in total. 0 added, 9 modified, 0 deleted:

  • chromium: 0 added, 9 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Twixes Twixes requested review from Twixes and a team and removed request for Twixes November 24, 2023 10:35
@posthog-bot posthog-bot removed the stale label Nov 27, 2023
@daibhin
Copy link
Contributor Author

daibhin commented Nov 27, 2023

Waiting on #18786 to be merged first. Is there any movement on that PR @corywatilo?

@corywatilo
Copy link
Contributor

Waiting on #18786

Done (sorry!), feel free to take it from there.

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a merge

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin force-pushed the dn-chore/remove-antd-tags branch from 40a0841 to 71a61b2 Compare November 29, 2023 13:18
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit 7295b73 into master Nov 29, 2023
@daibhin daibhin deleted the dn-chore/remove-antd-tags branch November 29, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants