Closes #1544 hide url controls on checkbox check event

[afarbman]

Changes

Hide unnecessary URL controls when editing a pageview action

Checklist

• All querysets/queries filter by Team (if this PR affects any querysets/queries)
• Backend tests (if this PR affects the backend)
• Cypress E2E tests (if this PR affects the front and/or backend)

[Twixes]

Ah, well, thank you, it's just that the URL text input box should disappear as well!

[jamesefhawkins]

@afarbman thank you so much for this. Email me (james at posthog.com) for something cool!

[afarbman]

Ah, well, thank you, it's just that the URL text input box should disappear as well!

oh, I see. will take care of it.

[Twixes]

At the moment, the URL matching mode selector is shown initially, even though URL matching is disabled. The URL input box meanwhile is shown all the time, when it shouldn't be if URL matching is disabled.

[Twixes]

A ternary with ? true : false is quite odd. !== already returns a boolean.

[afarbman]

done in 24bd7e4

[Twixes]

This would be better as a render condition (like so: this.isUrlChecked(step) & <div...) than dynamic display.

[afarbman]

done in a4be717

[Twixes]

Hm, unfortunately this is crashing the frontend for me when i go to http://localhost:8000/action and click "Page view".

[afarbman]

Hm, unfortunately this is crashing the frontend for me when i go to http://localhost:8000/action and click "Page view".

@Twixes fixed in b1b6803

[Twixes]

Ah, I'm still getting a crash when creating a new Page view Action, and URL input is by default shown on already existing Page view Actions even when URL is unchecked.
As we're making a general overhaul of the Actions page in #1841, I'll be closing this pull request – unfortunately this would cause conflicts. Sorry we didn't get this in, nevertheless we're tremendously thankful for your contribution @afarbman!