Migrate to flutter 2 #10
Conversation
lib/src/posthog.dart
Outdated
| Map<String, dynamic> properties, | ||
| Map<String, dynamic> options, | ||
| required String eventName, | ||
| required Map<String, dynamic> properties, |
There was a problem hiding this comment.
this seems to have diverged from lib/src/posthog_method_channel.dart where properties are correctly assigned as optional
There was a problem hiding this comment.
You're right, I'm going to make it nullable instead of required
| await Posthog.enable(); | ||
| Posthog.capture(eventName: 'Enabled capturing events!'); | ||
| await Posthog().enable(); | ||
| Posthog().capture( |
There was a problem hiding this comment.
Is this standard Dart indentation? (I don't know so I'm truly asking)
There was a problem hiding this comment.
Yeah, it's pretty odd for those who are used to other languages, but it's the default, I even used dart format in this file before saving the changes
|
@jonataslaw this worked for me and all the changes make sense! Thanks again for doing this. A few minor comments otherwise happy to merge. |
|
I just changed properties to nullable to be consistent with posthog_method_channel now |
|
lib pushed to pub.dev! Available version is now 2.0.0 |
Hi, I noticed that the project became incompatible with one of our projects after the Flutter 2 update, so I migrated it