This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
reviewed
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of Qs.
…rver into plugin-storage
Twixes
suggested changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests red 🆘
Fixed with an appropriate commit message. |
Twixes
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests green ❇️
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
* 0.6.1 * plugin storage extension * create plugin storage db * [WIP] use real postgres in tests * close resetTestDatabase connection, remove unused code * fix vm test * remove unused resolve * remove unused eslint * cleaner test command, which makes tests pass as well * fix benchmark/test * storage extension type from new scaffold version * use unique index and upsert for updating storage * remove team from plugin storage * Format createPluginStorage SQL with pgFormatter * remove await * check for process.env.NODE_ENV === 'test' directly instead of the jest workaround * init test dv * fix lazy-ass merge Co-authored-by: Michael Matloka <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage.get(key, defaultValue)
andstorage.set(key, value)
into meta, which act as buckets to store random JSON datacreatedb postgrest_test && yarn task:db-init
locally before running test.