This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Twixes
reviewed
Feb 8, 2021
Twixes
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are any results shown in the ClickHouse benchmark action. As a nit, the Postgres one's results are super noisy on the other hand
Twixes
approved these changes
Feb 11, 2021
4 tasks
* improve logging * ingest event in piscina * benchmark piscina ingestion * catch errors in ingestEvent * ingest in piscina worker * add KAFKA_BATCH_PARALELL_PROCESSING to ingest in parallel * split kafka event processing into batches * comment out plugin debug * do not pause kafka if worker busy --> we do one batch per server at a time anyway * fix broken test
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
* ingestion and e2e benchmarks * add e2e kafka benchmark * split benchmarks into 3 actions * fix script * fix test script folders * eslint --fix * fix clickhouse CI setup * random change to make github actions have another go * Parallel Ingestion (#144) * improve logging * ingest event in piscina * benchmark piscina ingestion * catch errors in ingestEvent * ingest in piscina worker * add KAFKA_BATCH_PARALELL_PROCESSING to ingest in parallel * split kafka event processing into batches * comment out plugin debug * do not pause kafka if worker busy --> we do one batch per server at a time anyway * fix broken test Co-authored-by: Michael Matloka <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
await processEvent
)Results on my 16" 2.4GHz i9 MBP for the E2E benchmarks with 4 workers:
There's definitely room for improvement!
Checklist