Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type response in PortkeyClient because of issues with inferred type #104

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

narengogi
Copy link
Contributor

@narengogi narengogi commented Sep 4, 2024

I had an issue with the inferred type of the post method inside the Portkey class because of the overloads in the create method that it invokes, No major change, only added type for the response in the interface

Tested by using the post method

#105

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@narengogi narengogi requested a review from csgulati09 September 4, 2024 07:15
@narengogi narengogi marked this pull request as draft September 4, 2024 07:19
@narengogi narengogi marked this pull request as ready for review September 4, 2024 11:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@VisargD VisargD merged commit ab3c244 into main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants