-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bambda Script to Filter on a Specific Highlight Color #16
Conversation
Thanks for the submission! It looks good, but can you revert the changes to the README.md as this will be updated automatically once the PR is merged. I'll update the docs to make this clear as I appreciate that this isn't at all obvious! If you want to see what the markdown will look like and tweak your bambda then if you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Changes made! Thanks for the tip about BambaChecker! It's ready for another review. |
Side note, the "author" field in my JavaDoc is markdown syntax and that made it through to the README.md as a valid clickable link. Just wanted to point that out in case that's not how you want that to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thanks for the heads up on the link - we'll discuss this further tomorrow and then either conclude the merge or request the link be removed. We'll also add some additional info to the submission guidelines around our stance on links. |
Bambda Contributions