Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bambda Script to Filter on a Specific Highlight Color #16

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Bambda Script to Filter on a Specific Highlight Color #16

merged 4 commits into from
Nov 30, 2023

Conversation

ncoblentz
Copy link
Contributor

@ncoblentz ncoblentz commented Nov 29, 2023

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda is in the correct directory
  • Bambda compiles and executes as expected

@PortSwiggerWiener
Copy link
Collaborator

Thanks for the submission! It looks good, but can you revert the changes to the README.md as this will be updated automatically once the PR is merged. I'll update the docs to make this clear as I appreciate that this isn't at all obvious!

If you want to see what the markdown will look like and tweak your bambda then if you run java -jar BambaChecker.jar from the root of your repo then it will update your local copy.

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ncoblentz
Copy link
Contributor Author

Changes made! Thanks for the tip about BambaChecker! It's ready for another review.

@ncoblentz
Copy link
Contributor Author

Side note, the "author" field in my JavaDoc is markdown syntax and that made it through to the README.md as a valid clickable link. Just wanted to point that out in case that's not how you want that to work.

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Hannah-PortSwigger
Copy link
Contributor

Hannah-PortSwigger commented Nov 29, 2023

Thanks for the heads up on the link - we'll discuss this further tomorrow and then either conclude the merge or request the link be removed.

We'll also add some additional info to the submission guidelines around our stance on links.

@Hannah-PortSwigger Hannah-PortSwigger merged commit 6f34ab6 into PortSwigger:main Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants