Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/py sec indices #1875

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Features/py sec indices #1875

merged 8 commits into from
Nov 29, 2024

Conversation

shivamka1
Copy link
Collaborator

@shivamka1 shivamka1 commented Nov 27, 2024 •
edited by miratepuffin
Loading

What changes were proposed in this pull request?

  • Changed add_property to add_properties
  • Exposed secondary index

Why are the changes needed?

  • No way to utilise secondary index's in python

Does this PR introduce any user-facing change? If yes is this documented?

Yes and yes

How was this patch tested?

Many new unit tests

Are there any further changes required?

Yes but post history fixes

@shivamka1 shivamka1 marked this pull request as ready for review November 29, 2024 13:30
@miratepuffin miratepuffin merged commit a8813ad into master Nov 29, 2024
19 checks passed
@miratepuffin miratepuffin deleted the features/py_sec_indices branch November 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miratepuffin miratepuffin miratepuffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivamka1 @miratepuffin