Feature/import as #1859
Merged
Feature/import as #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Couple of change suggested.
We also need to add a test for added edges from the same graph which lucas noticed deadlocks.
Can you make sure to run make tidy as you need to generate the stubs for these new functions.
If you can also quickly merge master to bring in the changes to allow iterators.
miratepuffin
approved these changes
Nov 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#1737: Add an import_as function for edges and nodes
Changed the force argument in import to 'merge' to better indicate what it is doing
Why are the changes needed?
When importing node/nodes or edge/edges from an existing graph user should be able to provide new id.
Does this PR introduce any user-facing change? If yes is this documented?
Yes, yes.
How was this patch tested?
Unit tests
Are there any further changes required?
No